Don't require smoltcp as a dev dependency #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we also need to remove the With the question mark there it won't automatically enable the smoltcp dep? |
|
Not sure if that's enough, I'll check later today. But thanks for the pointer! |
smoltcp is enabled through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hope is that this change is enough to avoid enabling all the features in #352. We should probably try and reduce feature spaghetti around smoltcp/utils/wifi/etc. in the future.
smoltcp is already an optional dependency enabled by features, I don't think it needs to be unconditionally enabled for tests/examples