Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove big-heap #367

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Remove big-heap #367

merged 2 commits into from
Nov 29, 2023

Conversation

bugadani
Copy link
Contributor

No description provided.

MabezDev
MabezDev approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnthonyGrondin
Copy link
Contributor

LGTM,
since we have a granular control over the heap size with configs, this feature is now redundant.

I believe it was only used for esp-rs/esp-mbedtls . The Cargo.toml and README.md there should be updated to reflect this change.

@bugadani bugadani mentioned this pull request Nov 29, 2023
Merged
bjoernQ
bjoernQ approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 591d1fc into esp-rs:main Nov 29, 2023
7 checks passed
@bugadani bugadani deleted the heap branch November 29, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @AnthonyGrondin @bjoernQ @MabezDev