Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock - update func signatures for latest glibc #9117

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Mock - update func signatures for latest glibc #9117

merged 2 commits into from
Jul 30, 2024

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Mar 31, 2024 •
edited
Loading 

/usr/include/stdlib.h:102:15: error: declaration of ‘double atof(const char*) noexcept’ has a different exception specifier
...etc...

/usr/include/string.h:506:15: error: declaration of ‘size_t strlcpy(char*, const char*, size_t) noexcept’ has a different exception specifier
...etc...

> rpm -q -f /usr/include/string.h /usr/include/stdlib.h
glibc-headers-x86-2.38-17.fc39.noarch
glibc-headers-x86-2.38-17.fc39.noarch

mcspr
mcspr commented Mar 31, 2024
View reviewed changes
cores/esp8266/stdlib_noniso.h Outdated Show resolved Hide resolved
tests/host/common/mock.h
#include <stddef.h>

#ifndef HAVE_NONISO
#include <stdlib_noniso.h>
Copy link
Collaborator Author

@mcspr mcspr Mar 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promised by TODO

overall libc stdlib comparison is tricky, don't see any feature flags with glibc 🤷
matching attributes with latest version breaks old one and vice versa, so these have to be hidden unless asked for actually, matching noexcept sort of works. assuming it is true for local implementation

@mcspr mcspr changed the title Mock - optionally hide locally implemented funcs Mock - update func signatures for latest glibc Apr 2, 2024
@mcspr
Mock - optionally hide locally implemented funcs
934a2e9 
glibc 2.38 includes strlcpy and strlcat, attempt to detect them before use
@mcspr
inverse dep, default to no strl funcs override
ccbcf17
@mcspr mcspr merged commit 3a5157e into esp8266:master Jul 30, 2024
28 checks passed
@mcspr mcspr deleted the mock/donthave branch July 30, 2024 23:24
@mcspr mcspr mentioned this pull request Jul 30, 2024
Merged
mcspr added a commit that referenced this pull request Jul 31, 2024
@mcspr
Mock - compatibility fix for shell calls (#9183)
1d6e50f 
echo does not seem to have escape mode with GH actions runner
trying to fix apparently broken makefile funcs from #9117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcspr