Skip to content

IPv6 support added #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

IPv6 support added #5

merged 1 commit into from
Dec 21, 2023

Conversation

HeMan
Copy link

@HeMan HeMan commented Sep 23, 2023

Copied code from stale PR me-no-dev#105

@HeMan
Copy link
Author

HeMan commented Nov 20, 2023

This should solve esphome/issues#5095

@jesserockz jesserockz merged commit 42a8644 into esphome:main Dec 21, 2023
@mathieucarbou
Copy link

Hello,
AsyncTCP is not compiling on ESP32 following the merge and publication of the new 2.1.0 tag:

.pio/libdeps/oss-esp32/AsyncTCP-esphome/src/AsyncTCP.cpp:753:2: error: #else without #if
 #else
  ^~~~
.pio/libdeps/oss-esp32/AsyncTCP-esphome/src/AsyncTCP.cpp:755:2: error: #endif without #if
 #endif
  ^~~~~
.pio/libdeps/oss-esp32/AsyncTCP-esphome/src/AsyncTCP.cpp:1020: error: unterminated #if
 #if LWIP_IPV4 && LWIP_IPV6

err_t err = dns_gethostbyname(host, &addr, (dns_found_callback)&_tcp_dns_found, this);
if(err == ERR_OK) {
#if LWIP_IPV4 && LWIP_IPV6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the removal of this ifdef might be causing the build issues.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I saw too. I switched back to the previous version in my project.

@HeMan HeMan mentioned this pull request Dec 25, 2023
kuba2k2 pushed a commit to libretiny-eu/AsyncTCP that referenced this pull request May 28, 2025
Fix compilation warnings when using LTO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants