-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves Mac install instructions #4034
Closed
+18
−6
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brew (and other system package installers) are "unsupported" as they are not maintained by core ESPHome maintainers and this is why we do not mention them in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jesserockz, I get it that you don't want to take on support. But Homebrew in this case is just a wrapper around the PyPi packages (see the forumula source) which just makes it more convenient for Mac users to install. So you could make the argument that since the actual code installed by homebrew is the exact same PyPi package as you would get from pip, then you are actually maintaining it!
FWIW I've been using the homebrew package for ESPHome for a long time and never had any issue.
But I'll follow your lead and if you don't want Homebrew mentioned at all, what's the next best alternative? Mac has a suitable version of Python that's shipped with Xcode command line tools which an end-user can install with
xcode-select --install
. Once that's installed, the Mac user should have access to pip3 normally. Ok to mention that?