-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog - Working on ESP devkits using WSL2 #149
Blog - Working on ESP devkits using WSL2 #149
Conversation
abc1903
to
47d818e
Compare
d045bba
to
a3348a2
Compare
Things that may be worth mentioning:
I've successfully managed to complete the tutorial. I can see, the new device using the Am I missing something? Is this the point where I need to use the |
a3348a2
to
7f15d25
Compare
Thank you, @mfialaf for the review. I have improved the description of the steps you have pointed out. Also updated the guide with the mentioned issue as we have solved this in person. Thank you for the help! |
Hi @jakub-kocka, thank you for the article. Can you please rebase? This will fix some issues and the CI will pass. Also, update the article date to a recent one. |
dd60ff5
to
c4aa3b2
Compare
Hi @pedrominatel, thanks for the review. However, rebase doesn't seem to help. |
Don't worry, @jakub-kocka . I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pedrominatel for the review and changes, it looks good to me.
I have left just a note about one sentence.
1b042b6
to
b97ad57
Compare
Editorial changes and added the author json file Changes on the introduction Publication date updated
7f8e2f7
to
ab03315
Compare
Not sure what is wrong with the product selector link. It keeps appearing as invalid in this PR. However, as soon as I push these changes to a test PR, the checks always pass successfully and the status of checks here immediately switches to all passed. This PR should fix such issues, hopefully, once and for all! |
Description
Related
Testing