CI/move link checking to pr checks #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-hollow
added a commit
that referenced
this pull request
Aug 14, 2024
* ci: move link checking to checks blocking pr merge * ci: include previously excluded nuttx-getting-started article from link checking
pedrominatel
pushed a commit
to pedrominatel/developer-portal
that referenced
this pull request
Sep 12, 2024
* ci: move link checking to checks blocking pr merge * ci: include previously excluded nuttx-getting-started article from link checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves link checking from the merge checks to PR checks. If the contributed changes have invalid links, the workflow being contributed will block the PR merge. The PR will be unblocked only after all the invalid links are fixed or added to
.lycheeignorefor a good reason.In addition to this PR, we need to create a ruleset for our main branch.
This PR also adds some links to the
.lycheeignorefile. These links require CAPTCHA checks, which is being reported by lychee as if the links are invalid. This is a known problem and ignoring such links is a standard solution.After this PR, we can also add workflows for
.webp