Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflow that rejects merging jpeg and png images #85

Merged
merged 4 commits into from
Aug 20, 2024
Merged

ci: add workflow that rejects merging jpeg and png images #85

merged 4 commits into from
Aug 20, 2024

Conversation

f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Aug 15, 2024 •
edited
Loading

This PR adds a workflow to check if the changes in a PR have PNG and JPEG images. If yes, it blocks the PR for merging and asks to convert the images to WebP.

It also includes other smaller workflows:

  • Adds a workflow that rejects filenames with spaces and asks, for example, to replace them with dashes.
  • Adds instructions to the existing link checking workflow, because without them, it is not clear now what to do with links that failed automatic checking but are still valid (for example due to CAPTCHA or login requests).
  • Adds a cron job to check links in all devportal content on the main branch every Monday.

@f-hollow f-hollow force-pushed the ci/reject-merging-png-jpg branch 2 times, most recently from abea3f5 to 06ab043 Compare August 16, 2024 09:03
@f-hollow f-hollow requested a review from horw August 16, 2024 09:20
@f-hollow
Copy link
Collaborator Author

@horw Thank you for your review! Implemented the comments.

Please take another look.

horw
horw reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@horw horw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-hollow f-hollow merged commit 6e18c89 into main Aug 20, 2024
3 checks passed
@f-hollow f-hollow deleted the ci/reject-merging-png-jpg branch August 20, 2024 06:03
pedrominatel pushed a commit to pedrominatel/developer-portal that referenced this pull request Sep 12, 2024
@f-hollow @pedrominatel
ci: add workflows for various quality checks (espressif#85)
0d6f8ce 
* ci: add workflow that rejects merging jpeg and png images

* ci: add workflow that rejects filenames with spaces

* ci: add guidelines to link checking workflow

* ci: add cron job to check links in all devportal content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horw horw horw approved these changes

@pedrominatel pedrominatel pedrominatel approved these changes

@georgik georgik Awaiting requested review from georgik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-hollow @pedrominatel @horw