Merge branch 'bugfix/handle_usb_disconnect' into 'master'

fix: Callback when USB port is disconnected, USB port not experimental anymore Closes ESF-174 See merge request espressif/esp-serial-flasher!126
espressif · Nov 4, 2024 · 8ece286 · 8ece286
2 parents b49d250 + 53fb930
commit 8ece286
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Kconfig b/Kconfig
@@ -18,7 +18,7 @@ menu "ESP serial flasher"
             bool "SPI (Only supports downloading to RAM)"
 
         config SERIAL_FLASHER_INTERFACE_USB
-            bool "USB (Experimental)"
+            bool "USB"
 
     endchoice
 

diff --git a/README.md b/README.md
@@ -26,7 +26,7 @@ Supported **target** microcontrollers:
 Supported hardware interfaces:
 - UART
 - SPI (only for RAM download)
-- USB CDC ACM (experimental)
+- USB CDC ACM
 
 For example usage check the [examples](/examples) directory.
 

diff --git a/port/esp32_usb_cdc_acm_port.c b/port/esp32_usb_cdc_acm_port.c
@@ -64,11 +64,11 @@ static void handle_usb_event(const cdc_acm_host_dev_event_data_t *event, void *u
 
     case CDC_ACM_HOST_DEVICE_DISCONNECTED:
         ESP_LOGI(TAG, "Device disconnected");
-        esp_loader_error_t deinit_status = loader_port_esp32_usb_cdc_acm_deinit();
-        assert(deinit_status == ESP_LOADER_SUCCESS);
         if (s_device_disconnected_callback != NULL) {
             s_device_disconnected_callback();
         }
+        esp_loader_error_t deinit_status = loader_port_esp32_usb_cdc_acm_deinit();
+        assert(deinit_status == ESP_LOADER_SUCCESS);
         break;
 
     case CDC_ACM_HOST_SERIAL_STATE: