Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Kconfig and esp32_camera.h #194

Conversation

DorBenHarush
Copy link

this PR moves the camera configuration fron the file.c to menuconfig. I tested this on my esp32-cam (AI-Thinker) and it works.

@me-no-dev
Copy link
Member

Hey :) that file.c is just an example. PINS need to be set in an actual application (like the web server example in ESP-WHO) and not in the driver itself. The driver is just a driver and does not care for the pins as long as they are properly selected in the application.

@me-no-dev me-no-dev closed this Oct 30, 2020
@DorBenHarush
Copy link
Author

DorBenHarush commented Oct 30, 2020

Hi, @me-no-dev my point in this pull request is that the pin configuraion can be selected in menuconfig instead of inside the application. Is it possible?
I want to make the pin selection process more eazy for micro-ros

@me-no-dev
Copy link
Member

The example I pointed to already has that in menuconfig. Again, it's not the driver that needs it, it's the particular final application 😄 https://github.com/espressif/esp-who/tree/master/examples/single_chip/camera_web_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants