Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stub binaries from esptool.py v4.5.dev1-2-g32e801484 #65

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

igrr
Copy link
Member

@igrr igrr commented Jan 12, 2023

  • Update the stubs, fixing the issue that the stub was not responding after uploading over USB_SERIAL_JTAG (Flash error with ESP32-C3 via USB_SERIAL_JTAG: Timeout #41 (comment))
  • Use original unmodified stub json files from esptool, simplifying future updates.
  • Bundle the json files and import them into target-specific files.
  • Note: stub text segment is no longer compressed, which increases the distribution size, somewhat. However this should be mitigated if the bundle is gzipped.

Testing

Can be tested at https://igrr.github.io/esptool-js/.

I've tested this on:

Tested by connecting and flashing a single 1.3 MB binary.

@igrr igrr changed the title Draft: update the stub binary for ESP32-C3 Use stub binaries from esptool.py v4.4 Jan 12, 2023
@igrr igrr marked this pull request as ready for review January 12, 2023 19:21
@igrr igrr requested a review from adwait-esp January 13, 2023 07:04
@liux-pro
Copy link
Contributor

Please note that recently there is an issue about esptool-v4.4, esp32s3, stub firmware.
esptool-v4.4 may be unstable.
espressif/esp-idf#10431

@igrr
Copy link
Member Author

igrr commented Jan 13, 2023

I see, thanks for the heads-up. I might downgrade to v4.3 then since v4.5 isn't released yet.

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM !

Copy link
Collaborator

@adwait-esp adwait-esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igrr igrr changed the title Use stub binaries from esptool.py v4.4 Use stub binaries from esptool.py v4.5.dev1-2-g32e801484 Jan 13, 2023
@igrr
Copy link
Member Author

igrr commented Jan 13, 2023

After checking with esptool.py maintainers, have decided to upgrade to the latest commit espressif/esptool@32e8014. It fixes one issue with the stub for USB_SERIAL_JTAG.

@igrr
Copy link
Member Author

igrr commented Jan 13, 2023

Have re-tested with the new stub, seems to work okay. I have one ESP32-S3 board with a CP2102 with which I get a timeout during flashing, but another similar ESP32-S3 & CP2102 board works fine. I think I'll merge this anyway, and investigate that issue separately (it might be the same as #47).

@igrr igrr merged commit 2411354 into espressif:main Jan 13, 2023
@balloob balloob mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants