fix: added coderabbit suggestions

espressif · Aug 5, 2024 · efb414b · efb414b
1 parent 00146d9
commit efb414b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/bundles/com.espressif.idf.core/src/com/espressif/idf/core/variable/JtagVariableResolver.java b/bundles/com.espressif.idf.core/src/com/espressif/idf/core/variable/JtagVariableResolver.java
@@ -74,10 +74,9 @@ private String generatePartOfConfigOptionsForBoard()
 				new DefaultBoardProvider().getDefaultBoard(targetName));
 		var boardConfigs = boardConfigMap.get(board);
 		var result = new StringBuilder();
-		var iterator = boardConfigs.iterator();
-		while (iterator.hasNext())
+		for (Object config : boardConfigs)
 		{
-			result.append(String.format("-f %s ", iterator.next()));//$NON-NLS-1$
+			result.append(String.format("-f %s ", config)); //$NON-NLS-1$
 		}
 		return result.toString();
 	}

diff --git a/...s/com.espressif.idf.core/src/com/espressif/idf/core/variable/OpenocdVariableResolver.java b/...s/com.espressif.idf.core/src/com/espressif/idf/core/variable/OpenocdVariableResolver.java
@@ -89,8 +89,8 @@ protected Path getOpenocdBinPath(ILaunchConfiguration configuration)
 
 	protected Path getOpenocdExecutable(ILaunchConfiguration configuration)
 	{
-		String exectuableName = EclipseUtils.getPreferenceValueForId(OPENOCD_PREFIX, EXECUTABLE_NAME, "", //$NON-NLS-1$
+		String executableName = EclipseUtils.getPreferenceValueForId(OPENOCD_PREFIX, EXECUTABLE_NAME, "", //$NON-NLS-1$
 				EclipseUtils.getProjectByLaunchConfiguration(configuration));
-		return Paths.get(exectuableName);
+		return Paths.get(executableName);
 	}
 }