Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Tracing plugin with espressif-ide #845

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Nov 1, 2023

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-1106)

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Launch espressif-ide
  • Go to preferences > General > Tracing

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Preferences

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

Refactor:

  • Modified the getServerLaunchTimeoutSeconds() method in bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/GdbServerBackend.java. This change improves the efficiency and performance of the code by retrieving the timeout value from preferences and assigning it to a variable. It also includes a debug mode print statement for the timeout value. These changes do not impact end-users directly but contribute to the overall stability and maintainability of the application.

Copy link

coderabbitai bot commented Nov 1, 2023

Walkthrough

The changes made are primarily focused on the bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF file. The org.eclipse.ui.trace has been added to the Require-Bundle section, enhancing the bundle's dependencies. Importantly, the integrity of the exported functions, global data structures, variables, interfaces, return values, and exceptions remains untouched.

Changes

File Path Summary
bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF Added org.eclipse.ui.trace to Require-Bundle. No changes to exported functions, global data structures, variables, interfaces, return values, or exceptions.
bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/GdbServerBackend.java Modified getServerLaunchTimeoutSeconds() method to retrieve timeout value from preferences and print it to console in debug mode. No changes to exported functions, global data structures, variables, interfaces, return values, or exceptions.

Poem

🍂 As November winds do blow,
In the code, new seeds we sow.
org.eclipse.ui.trace, a new friend in tow,
Yet our old pals, unchanged, in a row. 🐇

🌟 In the glow of the coder's light,
We dance in the autumn night.
Celebrating changes slight,
CodeRabbit leaps with all its might! 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 50f0564 and 65a9dc2.
Files selected for processing (1)
  • bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF (1 hunks)
Files skipped from review due to trivial changes (1)
  • bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 65a9dc2 and 8754bfa.
Files selected for processing (1)
  • bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/GdbServerBackend.java (1 hunks)
Files skipped from review due to trivial changes (1)
  • bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/GdbServerBackend.java

Copy link
Collaborator

@sigmaaa sigmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolipakakondal kolipakakondal marked this pull request as draft February 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants