Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ci): Build ESP-IDF examples in CI #24

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Apr 19, 2024

Describe the PR
Build esp-idf examples in CI

Additional context
During the espressif/tinyusb PR it is necessary to verify possibility of building all of the esp-idf examples with requesting changes.

This CI job does:

  • Add for all examples in folder espressif/tinyusb dependency with a path, pointing to the root of this repository
  • Build each example for --target all

During the build, the following dependencies are using (at the moment):

Processing 3 dependencies:
[1/3] espressif/esp_tinyusb (1.4.4)   /**< Current latest version of esp_tinyusb */
[2/3] espressif/tinyusb (*)           /**< Local tinyusb, from current PR */
[3/3] idf (5.3.0)                     /**< Version of esp-idf, based on the idf_ver matrix */

This changes are based on the changes in espressif/esp-usb#29.

@roma-jam roma-jam self-assigned this Apr 19, 2024
@roma-jam roma-jam force-pushed the feature/add_ci_idf_example_build branch 2 times, most recently from 6340946 to 797ea33 Compare April 19, 2024 09:27
@roma-jam roma-jam force-pushed the feature/add_ci_idf_example_build branch from 797ea33 to 0a6a246 Compare April 19, 2024 09:35
@roma-jam roma-jam marked this pull request as ready for review April 19, 2024 09:50
Copy link

@Dazza0 Dazza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roma-jam Left some minor comments, but LGTM.

.github/workflows/build_idf_examples.yml Show resolved Hide resolved
.github/workflows/build_idf_examples.yml Show resolved Hide resolved
.github/ci/override_managed_component.py Show resolved Hide resolved
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, for the additions. LGTM

@roma-jam
Copy link
Collaborator Author

@Dazza0 , thanks for the review.
All ideas is good and I will return to them a bit later (I have created a ticket for them).

Currently, I will go with merging changes like this to have at least some verification ATM.

@roma-jam roma-jam merged commit 9ef3d18 into release/v0.15 Apr 30, 2024
4 checks passed
@roma-jam roma-jam deleted the feature/add_ci_idf_example_build branch April 30, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants