-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1546] fix version switch by persist sys python in idfSetup #1384
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that both IDF versions installed are recognized by the extension, and the user can select both when creating a new project.
If the user is opening a project created with an older version of the extension, the user needs to run command "Select current ESP-IDF version" and select the IDF to be used in order for the project settings to be updated.
Description
Because ESP-IDF version now computes the virtual env python path from a
idf.pythonInstallPath
and current ESP-IDF version, there is an issue for v4.4.8 (uses embed Python 3.8) and v5.3.1 (use embed Python 3.11) calculates the wrong env path because this embed python is not persisted in idfSetup in extension global context. This leads to a wrong python env path calculated which failed the verification when showing the list of available IDF setups in the version switcher orESP-IDF: Configure ESP-IDF extension
command setup wizard.Fixes #1378
Type of change
Steps to test this pull request
ESP-IDF: Clear ESP-IDF Saved Setups
command.ESP-IDF: Configure ESP-IDF extension
to find existing ESP-IDF setup for v5.x.x. This will add this setup to the global extension context.ESP-IDF: Configure ESP-IDF extension
to find existing ESP-IDF setup for v4.4.x. This will add this setup to the global extension context.See that both ESP-IDF v5.3.1 and v4.4.8 are being shown in the list of existing setups in
ESP-IDF: Configure ESP-IDF extension
command setup wizard and status bar version switcher.See that both ESP-IDF v5.3.1 and v4.4.8 are being shown in the list of existing setups in
ESP-IDF: Configure ESP-IDF extension
command setup wizard and status bar version switcher.How has this been tested?
Manual testing as described above.
Test Configuration:
Checklist