Fixes for issue #93 #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willend
requested review from
mads-bertelsen and
nvaytet
and removed request for
mads-bertelsen
|
I will have a look modifying the CI to use conda-forge for deploying McStas and McStasScript. No need to think of merging before both this is in place and McStas 3.5.21 released. |
👍 Yes, the CI is still installing v3.4 from apt: https://github.com/ess-dmsc-dram/dmsc-school/blob/main/.github/workflows/deploy-book.yml#L47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since last run of the DMSC school a number of changes were introduced in
McStas/Union leading to the issue reported here: #93
Upstream McStas code has been fixed in McStasMcXtrace/McCode#1841 and will be included in next, forthcoming update release (will become v.3.5.21)
This PR
$MCSTAS)