Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize-postgres: include table name in logs for failed table alterations #2464

Merged
merged 1 commit into from
Feb 28, 2025
Merged

materialize-postgres: include table name in logs for failed table alterations #2464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion materialize-postgres/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ func (c *client) AlterTable(ctx context.Context, ta sql.TableAlter) (string, boi
return strings.Join(stmts, "\n"), func(ctx context.Context) error {
for _, stmt := range stmts {
if _, err := c.db.ExecContext(ctx, stmt); err != nil {
return err
log.WithField("stmt", stmt).Error("alter table statement failed")
return fmt.Errorf("executing alter table for table %s: %w", ta.Identifier, err)
}
}
return nil
Expand Down
Loading