Clean useless attributes on User #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First part which only ignore columns (drop will be in another commit). Some notes: * `context` used to store (sometimes) the siret of the user, this commit use (if there is a token) the siret associated to the authorization request (not perfect, neither the old solution tbh)
|
Le printemps est passé mais j'ai quand même envie de faire du ménage avant de re-faire du ménage pour https://github.com/etalab/siade/pull/858 |
Un3x
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part which only ignore columns (drop will be in another commit).
Some notes:
contextused to store (sometimes) the siret of the user, this commit use (if there is a token) the siret associated to the authorization request (not perfect, neither the old solution tbh)