Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce /stats.json #1147

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Introduce /stats.json #1147

merged 2 commits into from
Jul 26, 2023

Conversation

skelz0r
Copy link
Member

@skelz0r skelz0r commented Jul 26, 2023

Samuelfaure
Samuelfaure reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Samuelfaure Samuelfaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me parait OK minus la typo, mais j'espère que le client en face a un timeout bien réglé parce que ces liens mettent un moment à me DL les JSON

app/controllers/api_particulier/stats_controller.rb Outdated Show resolved Hide resolved
@Samuelfaure
Copy link
Contributor

BTW y'a pas un risque qu'on se fasse DDOS metabase par là si qqun nous spamme cet endpoint? J'ai l'impression que ça cache cependant

@skelz0r
Copy link
Member Author

skelz0r commented Jul 26, 2023

BTW y'a pas un risque qu'on se fasse DDOS metabase par là si qqun nous spamme cet endpoint? J'ai l'impression que ça cache cependant

Y'a en effet du cache, et c'est vrai pour /stats aussi dtf

@skelz0r
Copy link
Member Author

skelz0r commented Jul 26, 2023

Ça me parait OK minus la typo, mais j'espère que le client en face a un timeout bien réglé parce que ces liens mettent un moment à me DL les JSON

/stats.json est instant dtf donc aucun souci de charge sur l'app

@skelz0r skelz0r merged commit 9166165 into develop Jul 26, 2023
4 checks passed
@skelz0r skelz0r deleted the features/stats-json branch July 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelfaure Samuelfaure Samuelfaure left review comments

@Haelle Haelle Awaiting requested review from Haelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skelz0r @Samuelfaure