Skip to content

Commit

Permalink
Validation TableSchema : ignore casse des headers (#3363)
Browse files Browse the repository at this point in the history
  • Loading branch information
AntoineAugusti authored Aug 1, 2023
1 parent a9cb1bb commit 1183914
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions apps/shared/lib/validation/tableschema_validator.ex
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ defmodule Shared.Validation.TableSchemaValidator do

schema_url = schema_url(schema_name, schema_version || "latest")

# See https://go.validata.fr/api/v1/apidocs
# See https://api.validata.etalab.studio/apidocs
@validata_api_url
|> Map.put(:query, URI.encode_query(%{schema: schema_url, url: url}))
|> Map.put(:query, URI.encode_query(%{schema: schema_url, url: url, header_case: "false"}))
|> URI.to_string()
end

Expand Down
6 changes: 3 additions & 3 deletions apps/shared/test/validation/tableschema_validator_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ defmodule Shared.Validation.TableSchemaValidatorTest do
test "with a specific schema version" do
setup_schemas_response()
schema_version = "0.2.2"
query = URI.encode_query(%{schema: schema_url(@schema_name, schema_version), url: @url})
query = URI.encode_query(%{schema: schema_url(@schema_name, schema_version), url: @url, header_case: "false"})
expected_url = "https://validata-api.app.etalab.studio/validate?#{query}"

assert validator_api_url(@schema_name, @url, schema_version) == expected_url
end

test "with latest version" do
setup_schemas_response()
query = URI.encode_query(%{schema: schema_url(@schema_name, "latest"), url: @url})
query = URI.encode_query(%{schema: schema_url(@schema_name, "latest"), url: @url, header_case: "false"})
expected_url = "https://validata-api.app.etalab.studio/validate?#{query}"

assert validator_api_url(@schema_name, @url) == expected_url
Expand Down Expand Up @@ -166,7 +166,7 @@ defmodule Shared.Validation.TableSchemaValidatorTest do
defp read_json(filename), do: File.read!("#{__DIR__}/../fixtures/#{filename}")

defp validata_response_with_body(body, status_code \\ 200) do
query = URI.encode_query(%{schema: schema_url(@schema_name, "latest"), url: @url})
query = URI.encode_query(%{schema: schema_url(@schema_name, "latest"), url: @url, header_case: "false"})
url = "https://validata-api.app.etalab.studio/validate?#{query}"

Transport.HTTPoison.Mock
Expand Down

0 comments on commit 1183914

Please sign in to comment.