Add augerctl get
#82
Merged
Add augerctl get
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzshiming
force-pushed
the
feat/augerctl-get
branch
12 times, most recently
from
b9b5726
to
f73834d
Compare
wzshiming
force-pushed
the
feat/augerctl-get
branch
8 times, most recently
from
71180fe
to
05dc3f9
Compare
wzshiming
force-pushed
the
feat/augerctl-get
branch
2 times, most recently
from
3690b6e
to
d756687
Compare
jmhbnz
reviewed
Jul 28, 2024
There was a problem hiding this comment.
Thanks for raising this @wzshiming - Below are some initial suggestions, nothing major.
wzshiming
force-pushed
the
feat/augerctl-get
branch
from
d756687
to
cf2ce74
Compare
wzshiming
force-pushed
the
feat/augerctl-get
branch
4 times, most recently
from
7fbf360
to
b009206
Compare
wzshiming
force-pushed
the
feat/augerctl-get
branch
9 times, most recently
from
0912b12
to
968dbc7
Compare
|
done |
wzshiming
force-pushed
the
feat/augerctl-get
branch
3 times, most recently
from
7cffacc
to
8e580d4
Compare
|
1 minor comment. Otherwise lgtm |
Signed-off-by: Shiming Zhang <[email protected]>
wzshiming
force-pushed
the
feat/augerctl-get
branch
from
8e580d4
to
9d42b38
Compare
siyuanfoundation
approved these changes
Aug 13, 2024
This was referenced Aug 13, 2024
jmhbnz
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM - Many thanks for your patience with review, and for all your work on this @wzshiming
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, siyuanfoundation, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3
part of #62
Test
Preparation cluster
Create a cluster and expose etcd port, to facilitate the creation of a cluster using kwokctl, this can be any other k8s cluster
# brew install kwok kwokctl create cluster --etcd-port 2379Get a single resource
Get the kubernetes.default service
Get the all of the resource
Get the all of the etcd