Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support data persistence: integrate with storageClass #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support data persistence: integrate with storageClass #44

wants to merge 1 commit into from

Conversation

gdasson
Copy link
Member

@gdasson gdasson commented Jan 18, 2025

This PR adds support for data persistence using StorageClasses.

Supports setting VolumeClaimTemplate for the statefulset.

Fixes issue: #28

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gdasson
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @gdasson. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 20, 2025

/ok-to-test

ahrtr
ahrtr reviewed Jan 20, 2025
View reviewed changes
config/crd/bases/operator.etcd.io_etcdclusters.yaml
required:
- size
- storageClassName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't required. The default one will be used if not specified.

ahrtr
ahrtr reviewed Jan 20, 2025
View reviewed changes
api/v1alpha1/etcdcluster_types.go
Comment on lines +36 to +39
// StorageClassName is the name of the StorageClass to use for the etcd cluster.
StorageClassName string `json:"storageClassName"`
// VolumeSize is the size of the volume to use for the etcd cluster.
VolumeSize resource.Quantity `json:"volumeSize"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #28 (comment)

@gdasson gdasson mentioned this pull request Jan 29, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

Assignees
No one assigned
Labels
ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdasson @k8s-ci-robot @ahrtr