Skip to content

Commit

Permalink
api: address revive unexported-return issues
Browse files Browse the repository at this point in the history
Signed-off-by: Ivan Valdes <[email protected]>
  • Loading branch information
ivanvc committed Sep 26, 2024
1 parent c86c93c commit 3e5173b
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions api/etcdserverpb/raft_internal_stringer.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,17 @@ func (as *InternalRaftStringer) String() string {
return as.Request.String()
}

// txnRequestStringer implements a custom proto String to replace value bytes fields with value size
// TxnRequestStringer implements a custom proto String to replace value bytes fields with value size
// fields in any nested txn and put operations.
type txnRequestStringer struct {
type TxnRequestStringer struct {
Request *TxnRequest
}

func NewLoggableTxnRequest(request *TxnRequest) *txnRequestStringer {
return &txnRequestStringer{request}
func NewLoggableTxnRequest(request *TxnRequest) *TxnRequestStringer {
return &TxnRequestStringer{request}
}

func (as *txnRequestStringer) String() string {
func (as *TxnRequestStringer) String() string {
var compare []string
for _, c := range as.Request.Compare {
switch cv := c.TargetUnion.(type) {
Expand Down Expand Up @@ -155,10 +155,10 @@ func (m *loggableValueCompare) Reset() { *m = loggableValueCompare{} }
func (m *loggableValueCompare) String() string { return proto.CompactTextString(m) }
func (*loggableValueCompare) ProtoMessage() {}

// loggablePutRequest implements a custom proto String to replace value bytes field with a value
// LoggablePutRequest implements a custom proto String to replace value bytes field with a value
// size field.
// To preserve proto encoding of the key bytes, a faked out proto type is used here.
type loggablePutRequest struct {
type LoggablePutRequest struct {
Key []byte `protobuf:"bytes,1,opt,name=key,proto3"`
ValueSize int64 `protobuf:"varint,2,opt,name=value_size,proto3"`
Lease int64 `protobuf:"varint,3,opt,name=lease,proto3"`
Expand All @@ -167,8 +167,8 @@ type loggablePutRequest struct {
IgnoreLease bool `protobuf:"varint,6,opt,name=ignore_lease,proto3"`
}

func NewLoggablePutRequest(request *PutRequest) *loggablePutRequest {
return &loggablePutRequest{
func NewLoggablePutRequest(request *PutRequest) *LoggablePutRequest {
return &LoggablePutRequest{
request.Key,
int64(len(request.Value)),
request.Lease,
Expand All @@ -178,6 +178,6 @@ func NewLoggablePutRequest(request *PutRequest) *loggablePutRequest {
}
}

func (m *loggablePutRequest) Reset() { *m = loggablePutRequest{} }
func (m *loggablePutRequest) String() string { return proto.CompactTextString(m) }
func (*loggablePutRequest) ProtoMessage() {}
func (m *LoggablePutRequest) Reset() { *m = LoggablePutRequest{} }
func (m *LoggablePutRequest) String() string { return proto.CompactTextString(m) }
func (*LoggablePutRequest) ProtoMessage() {}

0 comments on commit 3e5173b

Please sign in to comment.