Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to release etcd v3.5.16 #18485

Closed
2 tasks done
ivanvc opened this issue Aug 22, 2024 · 21 comments
Closed
2 tasks done

Plan to release etcd v3.5.16 #18485

ivanvc opened this issue Aug 22, 2024 · 21 comments
Assignees
Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2024

What would you like to be added?

The etcd patch release criteria has been met for our release-3.5 stable release branch so we should release v3.5.16.

The list of commits included since the previous release is: v3.5.15...release-3.5:

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3516-tbc

List of pull requests we still need to backport from main to release-3.5 before the patch release is issued:

Release team

GitHub handle Role
@ivanvc Release lead
@jmhbnz Release advisor
@ArkaSaha30 Release shadow
@vivekpatani Release shadow

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

@liangyuanpeng
Copy link
Contributor

how about including #18480 in it.

@JalinWang
Copy link
Contributor

Do you consider this PR merged in 2021?
ref: Why is this needed

@ivanvc
Copy link
Member Author

ivanvc commented Aug 25, 2024

how about including #18480 in it.

@liangyuanpeng, I think it would be reasonable to add the bbolt version bump. We have #18488 and #18489, which are very close to being merged.

Do you consider this PR merged in 2021? ref: Why is this needed

@JalinWang, being this technically an (experimental) feature, I would like to hear @ahrtr / @serathius thoughts on this.

@ahrtr
Copy link
Member

ahrtr commented Aug 25, 2024

Do you consider this PR merged in 2021? ref: Why is this needed

I have no objection on this. Please also see #13018 (comment)

@ivanvc
Copy link
Member Author

ivanvc commented Aug 26, 2024

@JalinWang, do you want to help backporting #13018 to release-3.5 (after we merge #18495)?

@JalinWang
Copy link
Contributor

JalinWang commented Aug 26, 2024

@JalinWang, do you want to help backporting #13018 to release-3.5 (after we merge #18495)?

Sure. I will create a backporting PR per https://github.com/etcd-io/etcd/blob/4d42c0f86ac2762253a804fc5d9e6a25b80ef21b/Documentation/contributor-guide/release.md#patch-version-release (, where says the backporting commits "should be restricted to bug fixes and security patches" ? )

Update: I found the discussion about backporting here. The criteria seems to be not that clear :(

@ivanvc
Copy link
Member Author

ivanvc commented Aug 27, 2024

@JalinWang, with Benjamin's approval, feel free to do the cherry-pick :)

@ArkaSaha30
Copy link
Contributor

Hello @ivanvc , I would want to shadow the release of v3.5.16

@ivanvc
Copy link
Member Author

ivanvc commented Sep 3, 2024

Hi team (@ahrtr, @jmhbnz, @serathius, @spzala, @wenjiaswe), similar comment to the one from #18486. Would you want to be part of the release team for 3.5.16? I'm happy to lead this one, too, if needed.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 4, 2024

Hi @ArkaSaha30, can you help to do a pass on pull requests and issues that need to be backported? I'm using the following search: https://github.com/etcd-io/etcd/issues?page=1&q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-07-20, and https://github.com/etcd-io/etcd/issues?q=is%3Apullrequest+label%3Atype%2Fbug+created%3A%3E%3D2024-07-20.

Thanks!

@jmhbnz
Copy link
Member

jmhbnz commented Sep 4, 2024

Thanks for volunteering to lead 3.5.16 and 3.4.34 @ivanvc!

I see @ahrtr has agreed to be release advisor for 3.4.34, I am happy to be release advisor for 3.5.16.

I'm just coming back after being sick so I'll do some scope/backport review soon. Keen to set a date for the release and book in the release call 👍🏻

@ArkaSaha30
Copy link
Contributor

ArkaSaha30 commented Sep 4, 2024

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case?
ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

@ahrtr
Copy link
Member

ahrtr commented Sep 4, 2024

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case? ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

Thanks for the reminder. I think we should bump go1.22.7 for both 3.5.x and 3.4.x.

@jmhbnz jmhbnz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 5, 2024
@vivekpatani
Copy link
Contributor

@ivanvc @wenjiaswe I'd like to shadow pls, if possible. Thank you.

@ArkaSaha30
Copy link
Contributor

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case? ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

Go 1.22.7 has been released a few hours ago: https://groups.google.com/g/golang-dev/c/S9POB9NCTdk/m/b5s3OiTsAQAJ?utm_medium=email&utm_source=footer

@ivanvc
Copy link
Member Author

ivanvc commented Sep 5, 2024

@ArkaSaha30, thanks for the heads-up. I opened #18548 to track the update.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 7, 2024

Hi @vivekpatani, I was going to send a Slack message regarding this, but I don't know your username. Could you reach out to me on Slack (ivanvc)? Thanks.

Team (@ArkaSaha30, @jmhbnz, @vivekpatani), I know our time zones are spread, so I will suggest when we use it for our community meetings. Are you available next Tuesday (10th) or Wednesday (11th) at 11 a.m. PT? (which would be 6 a.m. NZST and 11:30 p.m. IST)

@jmhbnz
Copy link
Member

jmhbnz commented Sep 7, 2024

Team (@ArkaSaha30, @jmhbnz, @vivekpatani), I know our time zones are spread, so I will suggest when we use it for our community meetings. Are you available next Tuesday (10th) or Wednesday (11th) at 11 a.m. PT? (which would be 6 a.m. NZST and 11:30 p.m. IST)

Sounds great - I can do either of those options 🙂

@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

We just released v3.5.16. We found the following improvements to the documentation:

  1. Step 5 can be simplified to do a single-branch checkout
  2. Step 6 should clarify that the release directory is in /tmp/etcd-release-${VERSION}/etcd/release/
  3. Step 8 mention to add the "Release" label to the announcement message

@ArkaSaha30
Copy link
Contributor

We just released v3.5.16. We found the following improvements to the documentation:

  1. Step 5 can be simplified to do a single-branch checkout
  2. Step 6 should clarify that the release directory is in /tmp/etcd-release-${VERSION}/etcd/release/
  3. Step 8 mention to add the "Release" label to the announcement message

I will take it up

@ivanvc
Copy link
Member Author

ivanvc commented Sep 11, 2024

Closing, as there are no more remaining tasks. The release is here: https://github.com/etcd-io/etcd/releases/tag/v3.5.16

@ivanvc ivanvc closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

7 participants