-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release documentation #18572
Conversation
This commit will improve the release documentation guide by incorporating the following points: 1. Step 5 can be simplified to do a single-branch checkout 2. Step 6 should clarify that the release directory is in /tmp/etcd-release-${VERSION}/etcd/release/ 3. Step 8 mention to add the "Release" label to the announcement message Signed-off-by: ArkaSaha30 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 12 files with indirect coverage changes @@ Coverage Diff @@
## main #18572 +/- ##
==========================================
- Coverage 68.89% 68.85% -0.04%
==========================================
Files 420 420
Lines 35474 35474
==========================================
- Hits 24439 24426 -13
- Misses 9621 9631 +10
- Partials 1414 1417 +3 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for helping make the next release better @ArkaSaha30 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ArkaSaha30.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ArkaSaha30, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will improve the release documentation guide by incorporating the following points:
Reference: #18485 (comment)
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.