Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/benchmark: support --count-only for range #16196

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Jul 7, 2023

@fuweid
Copy link
Member Author

fuweid commented Jul 7, 2023

I think the failed case can be fixed by #16173

2023-07-07T07:34:49.8130130Z /home/runner/work/etcd/etcd/bin/etcdctl (/home/runner/work/etcd/etcd/bin/etcdctl_--insecure-transport=false_--insecure-skip-tls-verify=true_--endpoints=https://localhost:20000_user_add_:foobar_--interactive=false_-w_json) (37413): Error: empty user name is not allowed
2023-07-07T07:34:49.8130786Z     user_test.go:78: 
2023-07-07T07:34:49.8131419Z         	Error Trace:	/home/runner/work/etcd/etcd/tests/common/user_test.go:78
2023-07-07T07:34:49.8132759Z         	            				/home/runner/work/etcd/etcd/tests/framework/testutils/execute.go:38
2023-07-07T07:34:49.8133642Z         	            				/opt/hostedtoolcache/go/1.19.10/x64/src/runtime/asm_386.s:1326
2023-07-07T07:34:49.8135645Z         	Error:      	"match not found.  Set EXPECT_DEBUG for more info Errs: [unexpected exit code [128] after running [/home/runner/work/etcd/etcd/bin/etcdctl --insecure-transport=false --insecure-skip-tls-verify=true --endpoints=https://localhost:20000 user add :foobar --interactive=false -w json]], last lines:\n" does not contain "user name"
2023-07-07T07:34:49.8136609Z         	Test:       	TestUserAdd_Simple/ClientAutoTLS/empty_username_not_allowed
2023-07-07T07:34:49.8137197Z     logger.go:130: 2023-07-07T07:34:49.789Z	INFO	closing test cluster...
2023-07-07T07:34:49.8137987Z     logger.go:130: 2023-07-07T07:34:49.789Z	INFO	stopping server...	{"name": "TestUserAdd_SimpleClientAutoTLSempty_username_not_allowed-test-0"}

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member Author

fuweid commented Jul 12, 2023

ping @ahrtr @serathius

@ahrtr ahrtr merged commit 930dbbc into etcd-io:main Jul 12, 2023
@fuweid fuweid deleted the benchmark-support-range-countonly branch July 12, 2023 15:45
@fuweid
Copy link
Member Author

fuweid commented Jul 12, 2023

Thanks!

@jmhbnz jmhbnz mentioned this pull request Sep 25, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants