Clientv3 prevent nil pointer #16198
Merged
Clientv3 prevent nil pointer #16198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
reviewed
Jul 10, 2023
client/v3/concurrency/stm_test.go
Outdated
| @@ -0,0 +1,51 @@ | |||
| // Copyright 2016 The etcd Authors | |||
| }, | ||
| } | ||
|
|
||
| for _, test := range tests { |
There was a problem hiding this comment.
please consider to use test := test in Line 45. Just in case that new test var will shadow the old one, when we enable parallel mode.
There was a problem hiding this comment.
This comment applies to lots of other test cases as well.
Signed-off-by: Marcondes Viana <[email protected]>
ahrtr
approved these changes
Jul 10, 2023
chaochn47
approved these changes
Jul 11, 2023
|
Is there something else that I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #13400
Also add some tests for this specific case!