server: switch to semconv v1.17.0 #16288
Conversation
This is the latest semconv package used in etcd's dependencies. Switching to that version reduces the overall package dependencies of the project (and helps downstream projects which track this, e.g. Kubernetes). Signed-off-by: Stephen Kitt <[email protected]>
| @@ -23,7 +23,7 @@ import ( | |||
| "go.opentelemetry.io/otel/propagation" | |||
| "go.opentelemetry.io/otel/sdk/resource" | |||
| tracesdk "go.opentelemetry.io/otel/sdk/trace" | |||
| semconv "go.opentelemetry.io/otel/semconv/v1.4.0" | |||
| semconv "go.opentelemetry.io/otel/semconv/v1.17.0" | |||
There was a problem hiding this comment.
It seems that the latest version is v1.18.0? I just want to know if you intentionally selected 1.17.0.
There was a problem hiding this comment.
This is intentional — v1.17.0 is the latest version used in etcd’s dependencies.
There was a problem hiding this comment.
I am not sure if I miss anything. etcd depends on go.opentelemetry.io/otel's v1.14.0. The latest semconv version included in otel v1.14.0 is v1.18.0 per this link.
There was a problem hiding this comment.
The latest version included in otel is v1.18.0, the latest version actually used is v1.17.0: https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-go+semconv%2Fv+-path%3Asemconv&type=code
|
Hey @skitt - It looks like github actions fell over while running three of the etcd workflows. They report as still running but have failed with:
Example: https://github.com/etcd-io/etcd/actions/runs/5645732326?pr=16288 I don't have permission to re-run the so please consider a fresh force push of your commit to trigger that, otherwise we will need to wait for a maintainer to re trigger them. |
|
Rerun triggered;) |
|
Right, thanks @jmhbnz and @wenjiaswe! It seems the robustness job has failed in the same way — completed but still running as far as the GHA is concerned. |
There was a problem hiding this comment.
LGTM
https://github.com/etcd-io/etcd/actions/runs/5645732326/job/15292220462?pr=16288 it's completed but github doesn't update the status.
This is the latest semconv package used in etcd's dependencies. Switching to that version reduces the overall package dependencies of the project (and helps downstream projects which track this, e.g. Kubernetes).