Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add etcd_server_range_duration_seconds metric #16902

Closed
wants to merge 4 commits into from
Closed

feat: add etcd_server_range_duration_seconds metric #16902

wants to merge 4 commits into from

Conversation

RaviHari
Copy link
Contributor

@RaviHari RaviHari commented Nov 9, 2023 •
edited
Loading

fixes: #16866
add etcd_server_range_duration_seconds metric

@RaviHari RaviHari marked this pull request as ready for review November 9, 2023 20:54
jmhbnz
jmhbnz requested changes Nov 11, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @RaviHari - Could you please take a look at Integration or e2e tests for this new metric so we don't accidentally break it in future?

lavacat
lavacat suggested changes Nov 14, 2023
View reviewed changes
server/etcdserver/txn/txn.go Outdated Show resolved Hide resolved
server/etcdserver/txn/metrics.go Outdated Show resolved Hide resolved
server/etcdserver/txn/txn.go Outdated Show resolved Hide resolved
@RaviHari
Copy link
Contributor Author

Thanks for raising this @RaviHari - Could you please take a look at Integration or e2e tests for this new metric so we don't accidentally break it in future?

Hi @jmhbnz I looked at Integration and e2e tests it does not look like this change will break any of those tests.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 16, 2023

Hi @jmhbnz I looked at Integration and e2e tests it does not look like this change will break any of those tests.

Apologies I should have been more clear, I was asking if you could please add a test to ensure this metric does not get broken in future.

lavacat
lavacat reviewed Dec 12, 2023
View reviewed changes
server/etcdserver/txn/txn.go
)

const (
v3Version = "v3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think v3Version isn't used anymore.

@lavacat
Copy link

lavacat commented Dec 12, 2023

@RaviHari do you need help with figuring out where to add test?

@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@RaviHari RaviHari closed this Mar 30, 2024
@jmhbnz jmhbnz mentioned this pull request May 9, 2024
Closed
@ivanvc ivanvc mentioned this pull request May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavacat lavacat lavacat requested changes

@jmhbnz jmhbnz jmhbnz requested changes

Assignees
No one assigned
Labels
stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add etcd_server_range_duration_seconds metrics
3 participants
@RaviHari @jmhbnz @lavacat