Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: fix slack link for sig-etcd #16968

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

sharathsivakumar
Copy link
Contributor

@sharathsivakumar sharathsivakumar commented Nov 19, 2023

This pr fixes the slack link for sig-etcd in readme.md. More details here: kubernetes/community#7616

@sharathsivakumar
Copy link
Contributor Author

@jmhbnz @wenjiaswe A small change. Please take a look at it and let me know if further changes are needed.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sharathsivakumar. If we are updating the slack url let's do it everywhere in the repo for consistency and make sure we use the sig-etcd channel name:

-security/security-release-process.md:  - [etcd slack channel](https://kubernetes.slack.com/messages/C3HD8ARJ5
+security/security-release-process.md:  - [sig-etcd slack channel](https://kubernetes.slack.com/archives/C3HD8ARJ5

README.md Outdated Show resolved Hide resolved
Signed-off-by: Sharath Sivakumar <[email protected]>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharathsivakumar
Copy link
Contributor Author

@jmhbnz Done!

@serathius serathius merged commit a9cf27b into etcd-io:main Nov 19, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants