Force setting pre-vote flag even if it uses default value.

[joshuazh-x]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Ref #17455

[k8s-ci-robot]

Hi @joshuazh-x. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[serathius]

Not sure about the proposed approach, we don't want to set --pre-vote everywhere, just in robustness test. Please consider adding it to baseOptions

etcd/tests/robustness/scenarios.go

Lines 75 to 81 in 5c311d5

	baseOptions := []e2e.EPClusterOption{
	options.WithSnapshotCount(50, 100, 1000),
	options.WithSubsetOptions(randomizableOptions...),
	e2e.WithGoFailEnabled(true),
	e2e.WithCompactionBatchLimit(100),
	e2e.WithWatchProcessNotifyInterval(100 * time.Millisecond),
	}

[joshuazh-x]

Not sure about the proposed approach, we don't want to set --pre-vote everywhere, just in robustness test. Please consider adding it to baseOptions

etcd/tests/robustness/scenarios.go

Lines 75 to 81 in 5c311d5

	baseOptions := []e2e.EPClusterOption{
	options.WithSnapshotCount(50, 100, 1000),
	options.WithSubsetOptions(randomizableOptions...),
	e2e.WithGoFailEnabled(true),
	e2e.WithCompactionBatchLimit(100),
	e2e.WithWatchProcessNotifyInterval(100 * time.Millisecond),
	}

Simply adding an option to change prevote does not work, because any option same as the default one will be ignored.
Set --pre-vote with default value is equivalent to skipping it so I believe it won't cause any problem.

[serathius]

Right, forgot that now e2e framework uses defaults on the main branch to decide what flags to pass. Good find!

[joshuazh-x]

Fix goword check failure.

[serathius]

cc @ahrtr

[serathius]

Long term we might consider hardcoding differences between defaults on previous releases, however this should be a good solution for now.

[ahrtr]

Pls see my comment #17455 (comment)

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.