client/v3/watch.go: use fmt go pkg for gRPC metadata map printing

[mohamedawnallah]

Description

Addresses this issue #18303

[k8s-ci-robot]

Hi @mohamedawnallah. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[henrybear327]

/ok-to-test

[ahrtr]

Please also add an unit test

[mohamedawnallah]

Thanks a lot for the feedback, @ahrtr! It is much better now! 🙏 I have addressed all of the feedback.

[mohamedawnallah]

I've addressed the recent feedback 🙏. This might be off-topic, but I'm eager to contribute more to etcd. Could you suggest any specific issues or labels to work on? I'm just starting out and haven't found any labeled good-first-issue other than this one.

[ahrtr]

Could you suggest any specific issues or labels to work on?

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md

[ahrtr]

LGTM

nice work! Thank you for your first contribution!

[ivanvc]

Looking good. Thanks, @mohamedawnallah. I left a potential suggestion.

I also suggest removing the "Close" keyword from the pull request description, as Benjamin labeled the issue with a backport to 3.4 and 3.5, and it would be better not to close the parent issue automatically.

[ivanvc]

LGTM. We can add completeness in a follow-up/later. Thanks.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mohamedawnallah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahrtr]

@mohamedawnallah could you backport the PR to 3.5 and 3.4?

[mohamedawnallah]

@ahrtr Yeah I would love that it is my first time going through this backport process! I've just submitted two PRs for this:

• backport to release 3.4 PR: [3.4] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18311
• backport to release 3.5 PR: [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312