-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG/CHANGELOG-3.4.md: update changelog for gRPC metadata printing #18316
CHANGELOG/CHANGELOG-3.4.md: update changelog for gRPC metadata printing #18316
Conversation
Hi @mohamedawnallah. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 16 files with indirect coverage changes @@ Coverage Diff @@
## main #18316 +/- ##
==========================================
- Coverage 69.00% 68.97% -0.03%
==========================================
Files 417 417
Lines 35332 35333 +1
==========================================
- Hits 24380 24371 -9
- Misses 9540 9554 +14
+ Partials 1412 1408 -4 Continue to review full report in Codecov by Sentry.
|
b162b60
to
07a599f
Compare
07a599f
to
7d1721c
Compare
7d1721c
to
45f44c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo to fix then this is good to do :)
In this commit, we update the changelog for gRPC metadata printing in release 3.4 which is mainly a backport from PR etcd-io#18311. Signed-off-by: Mohamed Awnallah <[email protected]>
45f44c0
to
4bf1861
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mohamedawnallah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we update the changelog for gRPC metadata printing in release 3.4 which is mainly a backport from PR #18311.