migrate experimental-stop-grpc-service-on-defrag flag to feature gate. #18359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuanfoundation
force-pushed
the
fg-2
branch
5 times, most recently
from
5120ce4
to
5b1940d
Compare
|
/cc @serathius @ahrtr @fuweid |
serathius
reviewed
Jul 24, 2024
server/embed/config.go
Outdated
| // SetFeatureGatesFromExperimentalFlags sets the feature gate values if the feature gate is not explicitly set | ||
| // while their corresponding experimental flags are explicitly set. | ||
| // TODO: remove after all experimental flags are deprecated. | ||
| func SetFeatureGatesFromExperimentalFlags(fg featuregate.FeatureGate, getExperimentalFlagVal func(string) (bool, bool), featureGatesFlagName, featureGatesVal string) error { |
There was a problem hiding this comment.
Mark as deprecated? so it's clear it's not assumed to be the recommended option for new flags.
There was a problem hiding this comment.
Marking ExperimentalFlagToFeatureMap as deprecated, because that's where the actual experimental features are added.
serathius
reviewed
Jul 24, 2024
serathius
reviewed
Jul 24, 2024
serathius
reviewed
Jul 24, 2024
serathius
reviewed
Jul 24, 2024
serathius
reviewed
Jul 24, 2024
siyuanfoundation
force-pushed
the
fg-2
branch
2 times, most recently
from
1f09b93
to
95a1c65
Compare
|
/retest |
ahrtr
reviewed
Jul 25, 2024
siyuanfoundation
force-pushed
the
fg-2
branch
3 times, most recently
from
eef3b6f
to
ffb03a2
Compare
siyuanfoundation
force-pushed
the
fg-2
branch
2 times, most recently
from
398ee0b
to
89ab950
Compare
|
/retest |
ahrtr
reviewed
Jul 30, 2024
ahrtr
reviewed
Aug 2, 2024
12 tasks
Signed-off-by: Siyuan Zhang <[email protected]>
|
/retest |
serathius
approved these changes
Aug 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
part of #18023, an example of basic wiring from an existing experimental feature flag to the new feature gate.
final step of of breaking up #18234 into smaller PRs.