Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: add note regarding updating to go 1.22.7 #18553

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 6, 2024

Update 3.4 and 3.5 CHANGELOG to add a note regarding the Go update to 1.22.7.

Part of #18548.

To be merged after #18549, #18550.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (4a11ca6) to head (aecb137).

Current head aecb137 differs from pull request most recent head e3bade8

Please upload reports for the commit e3bade8 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18553      +/-   ##
==========================================
+ Coverage   68.73%   68.90%   +0.16%     
==========================================
  Files         420      420              
  Lines       35470    35470              
==========================================
+ Hits        24381    24439      +58     
+ Misses       9668     9616      -52     
+ Partials     1421     1415       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a11ca6...e3bade8. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 6, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit bf63f91 into etcd-io:main Sep 6, 2024
44 checks passed
@ivanvc ivanvc deleted the update-changelog-to-reflect-go-update-to-1.22.7 branch September 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants