Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-09-25] Bump dependency updates identified by dependabot #18636

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (1a08fb2) to head (f1d3cbe).

Current head f1d3cbe differs from pull request most recent head 79f31c7

Please upload reports for the commit 79f31c7 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 15 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18636      +/-   ##
==========================================
- Coverage   68.74%   68.68%   -0.06%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
- Hits        24427    24407      -20     
- Misses       9677     9696      +19     
- Partials     1431     1432       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a08fb2...79f31c7. Read the comment docs.

@henrybear327
Copy link
Contributor Author

/cc @ivanvc
/cc @ahrtr
/cc @jmhbnz

@henrybear327
Copy link
Contributor Author

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Henry.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrybear327 - A couple minor tweaks then this will be looking good to me.

api/go.mod Show resolved Hide resolved
In summary, the bump is performed for the following dependencies:
- go.opentelemetry.io/otel/exporters/otlp/otlptrace from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/metric from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/sdk from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/trace from v1.29.0 to v1.30.0

This commit also addressed the following issues
FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/api
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3
  - google.golang.org/genproto/googleapis/[email protected] from: go.etcd.io/etcd/api/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3
  - google.golang.org/genproto/googleapis/[email protected] from: go.etcd.io/etcd/server/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3
FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/api/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/pkg/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/testgrid-analysis/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/server/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3
  - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3
FAIL: inconsistent dependencies

Reference:
- etcd-io#18629
- etcd-io#18630
- etcd-io#18626
- etcd-io#18627

Signed-off-by: Chun-Hung Tseng <[email protected]>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @henrybear327

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Henry.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c86c93c into etcd-io:main Sep 25, 2024
37 checks passed
@henrybear327 henrybear327 deleted the dependencies/09_25_24 branch September 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants