Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Bump go toolchain to 1.23.1 #18644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main] Bump go toolchain to 1.23.1 #18644

wants to merge 1 commit into from

Conversation

henrybear327
Copy link
Contributor

@ivanvc ivanvc mentioned this pull request Sep 26, 2024
Open
10 tasks
@henrybear327
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (c86c93c) to head (8e8f585).

❗ Current head 8e8f585 differs from pull request most recent head dcdfead

Please upload reports for the commit dcdfead to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18644      +/-   ##
==========================================
- Coverage   68.77%   68.73%   -0.04%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
- Hits        24438    24426      -12     
- Misses       9668     9673       +5     
- Partials     1429     1436       +7

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86c93c...dcdfead. Read the comment docs.

@henrybear327
Copy link
Contributor Author

/retest

1 similar comment
@henrybear327
Copy link
Contributor Author

/retest

ivanvc
ivanvc approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Henry. By the way, it looks like there were a lot of test flakes 😟.

@henrybear327
Copy link
Contributor Author

LGTM. Thanks, Henry. By the way, it looks like there were a lot of test flakes 😟.

Yeah, I wasn't sure if it's just tonight because my other 2 PRs also are flaky :(

ahrtr
ahrtr approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved area/clientv3 area/etcdctl area/etcdutl area/performance area/testing area/tooling size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@henrybear327 @codecov-commenter @k8s-ci-robot @ivanvc @ahrtr