Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Bump go version to 1.22.8 #18669

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[3.5] Bump go version to 1.22.8 #18669

merged 1 commit into from
Oct 3, 2024

Conversation

PyAgni
Copy link
Contributor

@PyAgni PyAgni commented Oct 2, 2024

@k8s-ci-robot
Copy link

Hi @PyAgni. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Oct 2, 2024

/ok-to-test

@ivanvc ivanvc mentioned this pull request Oct 2, 2024
Closed
9 tasks
@ivanvc
Copy link
Member

ivanvc commented Oct 2, 2024

/retitle [3.5] Bump go version to 1.22.8

@k8s-ci-robot k8s-ci-robot changed the title Bump go version to 1.22.8 [3.5] Bump go version to 1.22.8 Oct 2, 2024
ivanvc
ivanvc approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Agni.

ahrtr
ahrtr approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit ce86965 into etcd-io:release-3.5 Oct 3, 2024
27 checks passed
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, PyAgni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc ivanvc mentioned this pull request Nov 7, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PyAgni @k8s-ci-robot @ivanvc @ahrtr