fix: use require.NoError instead of t.Fatal(err) in tests and tools packages

[mmorel-35]

There is no linter for this.
This uses testify instead of testing for
With

require.NoError(t, err)

require.Error(t, err)

instead of

if err != nil {
    t.Fatal(err)
}


if err == nil {
    t.Fatal(err)
}

This is only a part of this packages. I'll provide other PRs for the rest of it.

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/assign @wenjiaswe

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (f5acd17) to head (e4fce87).
Report is 2 commits behind head on main.

❗ Current head e4fce87 differs from pull request most recent head 3840876

Please upload reports for the commit 3840876 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18709      +/-   ##
==========================================
+ Coverage   68.72%   68.75%   +0.02%     
==========================================
  Files         420      420              
  Lines       35494    35494              
==========================================
+ Hits        24395    24404       +9     
+ Misses       9665     9661       -4     
+ Partials     1434     1429       -5     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5acd17...3840876. Read the comment docs.

[ivanvc]

/ok-to-test

[ivanvc]

Hi @mmorel-35, PTAL at the prow job pull-etcd-verify failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18709/pull-etcd-verify/1844226305705381888#1:build-log.txt%3A841

[ahrtr]

LGTM with a minor comment

Thanks

[ahrtr]

minor comment

Suggested change

	require.NoErrorf(t, cc.Put(ctx, "1st_test", smallbuf, config.PutOptions{}), "alarmTest: put kv error")
	err := cc.Put(ctx, "1st_test", smallbuf, config.PutOptions{})
	require.NoErrorf(t, err, "alarmTest: put kv error")

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@mmorel-35: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-e2e-arm64	5dabe45	link	true	/test pull-etcd-e2e-arm64
pull-etcd-unit-test-arm64	5dabe45	link	true	/test pull-etcd-unit-test-arm64
pull-etcd-integration-1-cpu-arm64	5dabe45	link	false	/test pull-etcd-integration-1-cpu-arm64
pull-etcd-e2e-386	5dabe45	link	true	/test pull-etcd-e2e-386
pull-etcd-verify	5dabe45	link	true	/test pull-etcd-verify
pull-etcd-unit-test-amd64	5dabe45	link	true	/test pull-etcd-unit-test-amd64
pull-etcd-unit-test-386	5dabe45	link	true	/test pull-etcd-unit-test-386
pull-etcd-govulncheck	5dabe45	link	true	/test pull-etcd-govulncheck
pull-etcd-integration-4-cpu-amd64	5dabe45	link	true	/test pull-etcd-integration-4-cpu-amd64
pull-etcd-build	5dabe45	link	true	/test pull-etcd-build
pull-etcd-integration-2-cpu-amd64	5dabe45	link	true	/test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-1-cpu-amd64	5dabe45	link	true	/test pull-etcd-integration-1-cpu-amd64
pull-etcd-integration-2-cpu-arm64	5dabe45	link	false	/test pull-etcd-integration-2-cpu-arm64
pull-etcd-e2e-amd64	5dabe45	link	true	/test pull-etcd-e2e-amd64
pull-etcd-integration-4-cpu-arm64	5dabe45	link	false	/test pull-etcd-integration-4-cpu-arm64
pull-etcd-robustness-arm64	5dabe45	link	true	/test pull-etcd-robustness-arm64
pull-etcd-robustness-amd64	5dabe45	link	true	/test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ahrtr]

LGTM with a minor comment

Thanks

Oops, approved the wrong PR.

[mmorel-35]

@ahrtr,

I screw something with my commits.
I'll do another branch

[ivanvc]

/retest

duh nevermind