Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release steps on how to share quay.io password #18710

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 9, 2024

Resolve #18611

cc @ivanvc @jmhbnz

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (f5acd17) to head (ad4c20e).

Current head ad4c20e differs from pull request most recent head bca44f5

Please upload reports for the commit bca44f5 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18710      +/-   ##
==========================================
+ Coverage   68.72%   68.76%   +0.03%     
==========================================
  Files         420      420              
  Lines       35494    35494              
==========================================
+ Hits        24395    24406      +11     
+ Misses       9665     9657       -8     
+ Partials     1434     1431       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5acd17...bca44f5. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@jmhbnz
Copy link
Member

jmhbnz commented Oct 9, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Benjamin.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Oct 9, 2024

Thanks both for the quick review!

@ahrtr ahrtr merged commit 6ffa69e into etcd-io:main Oct 9, 2024
39 checks passed
@ahrtr ahrtr deleted the release_1password_20241009 branch October 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Manage credentials using 1Password
5 participants