-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable errorlint in module go.etcd.io/etcd/client/v2
#18721
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @ahrtr |
ecda257
to
e7678fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18721 +/- ##
==========================================
+ Coverage 68.67% 68.80% +0.12%
==========================================
Files 420 420
Lines 35494 35488 -6
==========================================
+ Hits 24377 24416 +39
+ Misses 9684 9648 -36
+ Partials 1433 1424 -9 Continue to review full report in Codecov by Sentry.
|
e7678fc
to
83392b9
Compare
83392b9
to
7bf641b
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
7bf641b
to
c9f6dc7
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @mmorel-35
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This enable errorlint in module
go.etcd.io/etcd/client/v2
Related to #18576