[3.5] [serverWatchStream] terminate recvLoop on sws.close()

[veshij]

Backport of #18739 to 3.5

[k8s-ci-robot]

Hi @veshij. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ahrtr]

/ok-to-test

[ahrtr]

@ivanvc @jmhbnz do you know why the integration test on arm64 being blocked?

[ivanvc]

@ivanvc @jmhbnz do you know why the integration test on arm64 being blocked?

It looks like we don't have the actuated runners available anymore. They were supposed to be available until the end of the month. @jmhbnz mentioned it in kubernetes/test-infra#33715. We're working on migrating the ARM64 workloads to the prow infra. I spotted the release-3.5 branch, which James will work on ( kubernetes/test-infra#33715 (review)).

[ahrtr]

@ivanvc @jmhbnz do you know why the integration test on arm64 being blocked?

It looks like we don't have the actuated runners available anymore. They were supposed to be available until the end of the month. @jmhbnz mentioned it in kubernetes/test-infra#33715. We're working on migrating the ARM64 workloads to the prow infra. I spotted the release-3.5 branch, which James will work on ( kubernetes/test-infra#33715 (review)).

Thanks for the clarification. The arm64 support should be available until we finish migration all of them, including main and all stable releases, to prow.

We need to unblock the PRs for 3.5.

[ivanvc]

Thanks for the clarification. The arm64 support should be available until we finish migration all of them, including main and all stable releases, to prow.

We need to unblock the PRs for 3.5.

I'm not sure if that's something you can request from the CNCF. From looking at the error message, it seems like we don't have runners available anymore (https://github.com/etcd-io/etcd/actions/runs/11528005687/job/32094556498?pr=18784):

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

I can work tomorrow on migrating the ARM64 integration tests from the release-3.5 branch. Therefore, the jobs will run on the prow infra instead.

[ahrtr]

I can work tomorrow on migrating the ARM64 integration tests from the release-3.5 branch. Therefore, the jobs will run on the prow infra instead.

Thanks.

[ivanvc]

/retitle [3.5] [serverWatchStream] terminate recvLoop on sws.close()

[ivanvc]

/test all

[ivanvc]

/test pull-etcd-smoke-4-cpu-arm64

[ivanvc]

Hi @ahrtr, James and I worked today to enable the ARM64 prow jobs. The CI for this pull request will be broken until #18802 is merged and this PR is rebased.

[ivanvc]

From a backport point of view, it LGTM. Thanks, @veshij.

[ahrtr]

Hi @ahrtr, James and I worked today to enable the ARM64 prow jobs. The CI for this pull request will be broken until #18802 is merged and this PR is rebased.

Thank you both! @ivanvc @jmhbnz

[ahrtr]

LGTM

Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius, veshij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahrtr]

Link to #18704