-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable int-conversion rule of perfsprint #18859
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
209c7cd
to
adae3ec
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
adae3ec
to
1e09dbe
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18859 +/- ##
=======================================
Coverage 68.80% 68.81%
=======================================
Files 420 420
Lines 35532 35532
=======================================
+ Hits 24448 24451 +3
+ Misses 9662 9657 -5
- Partials 1422 1424 +2 Continue to review full report in Codecov by Sentry.
|
/assign @ahrtr |
/ok-to-test |
This fixes int-conversion rule from perfsprint
This helps avoid unnecessary memory allocations.
It doesn't include server and tests folder as they have a lot of impacted files