scripts/test_images.sh: refactor to import job into the prow infrastructure #19305
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 14 files with indirect coverage changes @@ Coverage Diff @@
## main #19305 +/- ##
==========================================
- Coverage 68.84% 68.83% -0.02%
==========================================
Files 420 420
Lines 35693 35693
==========================================
- Hits 24573 24568 -5
- Misses 9698 9702 +4
- Partials 1422 1423 +1 Continue to review full report in Codecov by Sentry.
|
|
/test pull-etcd-release-tests |
2 similar comments
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
2 similar comments
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
ivanvc
force-pushed
the
test-prow-job
branch
2 times, most recently
from
5093328 to
e0007d7
Compare
|
/test pull-etcd-release-tests |
|
/test pull-etcd-release-tests |
|
/test pull-etcd-verify |
* Wrap script in functions, add a main function, and call them from it. * Make environment variables local inside the function scope to avoid unexpected behaviors by the running environment-supplied variables. * Fix the typo in the "REPOSITORY" environment variable. * Rename the input "IMAGE" to "TEST_IMAGE" to avoid clashing with the environment variable from the Prow infrastructure. Signed-off-by: Ivan Valdes <[email protected]>
|
/test pull-etcd-release-tests pull-etcd-verify |
ivanvc
changed the title
|
/test pull-etcd-integration-1-cpu-amd64 |
|
Let me know if you want me to start a fresh PR. I reused the one I used to test that the prow job worked. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After merging etcd-io/etcd#19305, this job is passing. Allow it to run for some time before removing the optional flag.
After merging etcd-io/etcd#19305, this job is passing. Allow it to run for some time before removing the optional flag.
After merging etcd-io/etcd#19305, this job is passing. Allow it to run for some time before removing the optional flag.
While importing the release tests into the Prow infrastructure, after some exploration, I found that the current script didn't work correctly because it allows an input environment variable "IMAGE," which in the Prow infra points to the image from the container. This made the
scripts/test_images.shscript fail. So, I took an opportunity to rewrite the script in a more modular way while fixing this issue.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.