Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an StorageRecorder interface to fix unexported-return #19341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aladesawe
Copy link
Contributor

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aladesawe
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @aladesawe. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aladesawe
Copy link
Contributor Author

Pulled from PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (92673d1) to head (cc79a88).
Report is 165 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/mock/mockstorage/storage_recorder.go 95.00% <100.00%> (ø)

... and 53 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19341      +/-   ##
==========================================
+ Coverage   68.79%   68.82%   +0.03%     
==========================================
  Files         420      420              
  Lines       35629    35716      +87     
==========================================
+ Hits        24510    24583      +73     
- Misses       9700     9708       +8     
- Partials     1419     1425       +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92673d1...cc79a88. Read the comment docs.

storage.Storage
testutil.Recorder
}

type storageRecorder struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative & simpler solution is to rename storageRecorder to StorageRecorder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants