-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an StorageRecorder interface to fix unexported-return #19341
base: main
Are you sure you want to change the base?
Create an StorageRecorder interface to fix unexported-return #19341
Conversation
Signed-off-by: adeyemi <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aladesawe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pulled from PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 53 files with indirect coverage changes @@ Coverage Diff @@
## main #19341 +/- ##
==========================================
+ Coverage 68.79% 68.82% +0.03%
==========================================
Files 420 420
Lines 35629 35716 +87
==========================================
+ Hits 24510 24583 +73
- Misses 9700 9708 +8
- Partials 1419 1425 +6 Continue to review full report in Codecov by Sentry.
|
storage.Storage | ||
testutil.Recorder | ||
} | ||
|
||
type storageRecorder struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative & simpler solution is to rename storageRecorder
to StorageRecorder
.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.