-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: fixup raftLog initialization #151
Conversation
Hi @serathius. Could you please merge this and #147? These are pretty trivial test-only clean-ups, but I have other useful work on top of them and would like to avoid the trouble of maintaining these branches or duplicating these cleanups across PRs. |
Please rebase this PR. |
Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
@ahrtr done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Most change are mechanical changes. cc @erikgrinaker to take a second look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR consolidates the
raftLog
struct initialization into a single return statement. It also makes all unit-tests use thenewLog
constructor function to initialize a log, instead of populating the struct manually.Changes to the
unstable
/raftLog
structures should by default not require fixing boilerplate in tests.Related to #146
Blocks #139