Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Replace t.error/fatal with assert/request in [/quorum] #187

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

MrDXY
Copy link
Contributor

@MrDXY MrDXY commented Mar 21, 2024

Refactor: Replacing t.Error/t.Fatal with assert/require

This commit tries to eliminate boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.

Changes Made:

  • Replaced instances of t.Error with assert
  • Replaced instances of t.Fatal with require

Affected Files:

  • [quorum/datadriven_test.go]
  • [quorum/quick_test.go]

Part of: #146

@MrDXY MrDXY mentioned this pull request Mar 21, 2024
6 tasks
@ahrtr ahrtr merged commit a83a3bb into etcd-io:main Mar 21, 2024
9 checks passed
@MrDXY MrDXY deleted the replace-test-errors-with-assert-quorum branch March 21, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants