Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move go version to dedicated .go-version file #193

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

MrDXY
Copy link
Contributor

@MrDXY MrDXY commented Apr 7, 2024

Motivation:

Introduce a .go-version file to make it easier to maintain go versions among multiple files that use it.

Changes Made:

  • Added a .go-version file to the root directory of the project.
    • The .go-version file contains the desired Go version (e.g., go1.22.2) required for this project.
  • Updated the project's related workflow files.
    • .github/workflows/govuln.yaml
    • .github/workflows/static-analysis.yaml
    • .github/workflows/test_amd64.yaml
    • .github/workflows/test_template.yaml

Reference:
#191 (comment)

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @MrDXY

@ahrtr ahrtr merged commit d9cb993 into etcd-io:main Apr 8, 2024
9 checks passed
@MrDXY MrDXY deleted the adopt-go-version-file branch April 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants