Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loading skeleton components #41

Merged
merged 27 commits into from
Apr 16, 2024
Merged

feat: loading skeleton components #41

merged 27 commits into from
Apr 16, 2024

Conversation

Carl-J-M
Copy link
Contributor

@Carl-J-M Carl-J-M commented Mar 1, 2024 •
edited
Loading

LoadingButton
LoadingImage
LoadingText

@Carl-J-M Carl-J-M changed the title feat: basic experiment for wrapping loading skeleton feat: loading skeleton components Mar 25, 2024
@Carl-J-M Carl-J-M marked this pull request as ready for review April 9, 2024 16:39
gavmck
gavmck previously requested changes Apr 10, 2024
View reviewed changes
components/content/LoadingButton/LoadingButton.css Outdated Show resolved Hide resolved
components/content/LoadingButton/LoadingButton.stories.ts Outdated Show resolved Hide resolved
components/content/LoadingButton/LoadingButton.ts Outdated Show resolved Hide resolved
components/content/LoadingButton/LoadingButton.css Outdated Show resolved Hide resolved
components/content/LoadingImage/LoadingImage.css Outdated Show resolved Hide resolved
components/content/LoadingButton/LoadingButton.stories.ts Outdated Show resolved Hide resolved
components/content/LoadingImage/LoadingImage.stories.ts Outdated Show resolved Hide resolved
components/content/LoadingText/LoadingText.stories.ts Outdated Show resolved Hide resolved
components/content/LoadingText/LoadingText.ts Outdated Show resolved Hide resolved
styles/tokens/transition.css Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 15, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gavmck gavmck dismissed their stale review April 16, 2024 15:01

Paired, getting re-review

@mergify mergify bot merged commit f8f1599 into main Apr 16, 2024
6 checks passed
@mergify mergify bot deleted the feat/etch-371-loading-skeleton branch April 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavmck gavmck gavmck left review comments

@ella-etch ella-etch ella-etch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carl-J-M @gavmck @ella-etch