Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input width overflow #53

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Input width overflow #53

merged 1 commit into from
Apr 27, 2024

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Apr 26, 2024

Screenshot 2024-04-26 at 14 40 42

  • Min-width fix needed in some browsers caused by diamond-input being display: flex
  • Applying only min-width can still leave the underlying input overflowing so width 100% has been applied

@DanWebb DanWebb self-assigned this Apr 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DanWebb DanWebb merged commit 2a0af91 into main Apr 27, 2024
6 checks passed
@DanWebb DanWebb deleted the feature/etch-532-diamond-input-width-overflow branch April 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavmck gavmck gavmck approved these changes

@Carl-J-M Carl-J-M Awaiting requested review from Carl-J-M

@ella-etch ella-etch Awaiting requested review from ella-etch

Assignees

@DanWebb DanWebb

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanWebb @gavmck